Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt to 2.0.1 #863

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@tanishiking
Copy link
Contributor

commented Aug 13, 2019

I just released scalafmt v2.0.1 that contains the change which fixes scalameta/scalafmt#1442
Some tests are failing, but they seem to have nothing to do with this change.

@tanishiking tanishiking force-pushed the tanishiking:update-scalafmt-201 branch 2 times, most recently from 874de76 to 3c18296 Aug 13, 2019
Copy link
Member

left a comment

Thank you so much for fixing that :)
Just a tiny change then we can merge

build.sbt Outdated
val scalafmt = "2.0.0"
val scalafmtDynamic = "2.0.0-RC4" // Not v2.0.0 because it has a regression https://github.com/scalameta/scalafmt/issues/1442
val scalafmt = "2.0.1"
val scalafmtDynamic = "2.0.1"

This comment has been minimized.

Copy link
@gabro

gabro Aug 13, 2019

Member

let's remove this variable and only use scalafmt (it was like this before the regression)

This comment has been minimized.

Copy link
@tanishiking

tanishiking Aug 13, 2019

Author Contributor

fixed 1f7379a 👍

@tanishiking tanishiking force-pushed the tanishiking:update-scalafmt-201 branch from 3c18296 to 1f7379a Aug 13, 2019
@gabro
gabro approved these changes Aug 13, 2019
@gabro

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

The two failures seem unrelated. @tgodzik the Azure one seems deterministic: it's resolving a slightly different version of the artifacts in the TVP tests (a new version of the deps came out, it looks like)

@gabro gabro merged commit 054b2b5 into scalameta:master Aug 13, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
scalameta.metals Build #20190813.4 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tanishiking tanishiking deleted the tanishiking:update-scalafmt-201 branch Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.