Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TreeViewSlowSuite tests #864

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@gabro
Copy link
Member

commented Aug 13, 2019

This should fix the current failures, but it's definitely not permanent, given the nature of the fix.

Any idea on how to make these more stable, @tgodzik / @olafurpg?

@gabro gabro requested a review from tgodzik Aug 13, 2019
@tgodzik

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

This should fix the current failures, but it's definitely not permanent, given the nature of the fix.

Any idea on how to make these more stable, @tgodzik / @olafurpg?

It seems transitive dependencies change and I am not entirely sure if this test can be stable at all.

We could check for a subset of dependencies and ignore the ones that are changing, but that doesn't look perfect either.

@gabro gabro merged commit 5e49595 into scalameta:master Aug 13, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190813.7 succeeded
Details
@gabro gabro deleted the gabro:fix-tvp-tests branch Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.