Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add package objects when creating package.scala file #866

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Aug 13, 2019

No description provided.

@tgodzik tgodzik requested a review from marek1840 Aug 13, 2019
Copy link
Member

left a comment

This is a cool feature :)

I've left a couple of comments/suggestions

Copy link
Collaborator

left a comment

I have nothing to add over what @gabro has mentioned.

@tgodzik tgodzik force-pushed the tgodzik:add-package-object branch from 0a16d46 to 22ddb41 Aug 14, 2019
@gabro
gabro approved these changes Aug 14, 2019
Copy link
Member

left a comment

👍 LGTM

@tgodzik tgodzik merged commit 656ed8c into scalameta:master Aug 14, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190814.1 succeeded
Details
@tgodzik tgodzik deleted the tgodzik:add-package-object branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.