Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make presentation compiler work on 2.12.9 #872

Merged
merged 3 commits into from Aug 25, 2019

Conversation

@gabro
Copy link
Member

commented Aug 24, 2019

Fixes #868

Same as #871, but open against the right repo.

gabro added 2 commits Aug 24, 2019
The optimizations avoids re-downloading semanticdb-scalac-core (which is
a transitive dependency of mtags) if the semanticdb-scalac plugin is already
installed.

For reasons that we haven't yet investigated, this breaks the PC-based
features on 2.12.9, throwing this exception:

```
Exception in thread "pool-12-thread-2" java.lang.AbstractMethodError:
Method scala/meta/internal/pc/MetalsGlobal$$anon$1.scala$tools$nsc$typechecker$Contexts$_setter_$scala$tools$nsc$typechecker$Contexts$$symbolLookupCache_$eq(Lscala/reflect/internal/util/ReusableInstance;)V is abstract
```

Since the optimization is clearly breaking semantics, we remove it for now.
We don't use BuildInfo.scala212 since Metals itself has not migrated to
2.12.9 yet.
@gabro gabro changed the title 2.12.9 fixes Make presentation compiler work on 2.12.9 Aug 24, 2019
@gabro gabro requested a review from olafurpg Aug 24, 2019
.extract(newState)
.runTask(publishLocal.in(mtags), newState)
Project
.extract(s)
.runTask(publishLocal.in(interfaces), s)

This comment has been minimized.

Copy link
@gabro

gabro Aug 24, 2019

Author Member

@olafurpg Travis is complaining about a missing mtags-interfaces, which I guess is normal now that the optimization about transitive dependencies is not in place anymore?

I've added this to run interfaces/publishLocal in addition to mtags/publishLocal before running slow tests

@gabro gabro removed the merge when green label Aug 24, 2019
@gabro

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

AppVeyor failure seems spurious. Merging to unblock testing this

@gabro gabro merged commit 28dcced into scalameta:2.12.9-fixes Aug 25, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190824.4 succeeded
Details
@gabro gabro deleted the gabro:2.12.9-fixes branch Aug 25, 2019
@gabro gabro restored the gabro:2.12.9-fixes branch Aug 25, 2019
@gabro gabro deleted the gabro:2.12.9-fixes branch Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.