Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make presentation compiler work on 2.12.9 #872
The optimizations avoids re-downloading semanticdb-scalac-core (which is a transitive dependency of mtags) if the semanticdb-scalac plugin is already installed. For reasons that we haven't yet investigated, this breaks the PC-based features on 2.12.9, throwing this exception: ``` Exception in thread "pool-12-thread-2" java.lang.AbstractMethodError: Method scala/meta/internal/pc/MetalsGlobal$$anon$1.scala$tools$nsc$typechecker$Contexts$_setter_$scala$tools$nsc$typechecker$Contexts$$symbolLookupCache_$eq(Lscala/reflect/internal/util/ReusableInstance;)V is abstract ``` Since the optimization is clearly breaking semantics, we remove it for now.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.