Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch ShutdownReq exception from stopping a presentation compiler. #873

Merged
merged 1 commit into from Aug 25, 2019

Conversation

@olafurpg
Copy link
Member

commented Aug 25, 2019

This is an attempt to reduce flaky test failures. Supersedes #861

@olafurpg olafurpg requested a review from tgodzik Aug 25, 2019
@olafurpg

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

The Azure job passed without a flaky failure, which is a good signal. Travis failed with a flaky download error in Maven.

@olafurpg

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

Appveyor is failing due to

Exception in thread "pool-507-thread-29" java.lang.OutOfMemoryError: Java heap space
	at java.util.Arrays.copyOf(Arrays.java:3236)
	at sun.misc.IOUtils.readFully(IOUtils.java:60)

I'm looking forward to try out the new GitHub CI...

This is an attempt to reduce flaky test failures.
@olafurpg olafurpg force-pushed the olafurpg:flaky branch from 8c720f4 to ee537d6 Aug 25, 2019
@olafurpg

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

Unrelated flaky test failure on Azure ReferenceSlowSuite.edit-distance

@olafurpg

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

This would have prevented the flaky test failure in #877 so I'm gonna go ahead and merge it.

@olafurpg olafurpg merged commit 9df4506 into scalameta:master Aug 25, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
scalameta.metals Build #20190825.8 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@olafurpg olafurpg deleted the olafurpg:flaky branch Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.