Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of early intializers #877

Merged
merged 1 commit into from Aug 25, 2019

Conversation

@gabro
Copy link
Member

commented Aug 25, 2019

⚠️ This is a test, to see how the CI likes it.

Early initializers are deprecated in 2.13 in favor of trait parameters (landing in
2.14). For the time being, we replace them using an intermediate class
workaround

They are deprecated in 2.13 in favor of trait parameters (landing in
2.14). For the time being, we replace them using an intermediate class
workaround.

Source for the workaround here:
scala/scala#6888 (comment)
Copy link
Member

left a comment

LGTM 👍 This is awesome! Ignoring flaky unrelated test failures in Azure and Appveyor

@olafurpg olafurpg marked this pull request as ready for review Aug 25, 2019
@olafurpg olafurpg merged commit 36fc570 into scalameta:master Aug 25, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
scalameta.metals Build #20190825.11 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gabro gabro deleted the gabro:early-init-removal branch Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.