Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not closing streams when using Files.list #892

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Sep 2, 2019

This fixes the issue that we had when not closing streams when looking for subdirectories.

We might add same method to WalkFiles and simplify a lot of the code. I don't really think we need a whole new library here.

Copy link
Collaborator

left a comment

LGTM, let's revisit the issue once the release is done.

@tgodzik tgodzik requested a review from olafurpg Sep 2, 2019
@tgodzik tgodzik merged commit cc9eadb into scalameta:master Sep 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190902.3 succeeded
Details
@tgodzik tgodzik deleted the tgodzik:fix-file-leaks branch Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.