Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website overview and add information about Eclipse #894

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Sep 3, 2019

No description provided.

@tgodzik tgodzik requested a review from olafurpg Sep 3, 2019
Copy link
Member

left a comment

I'm very excited to see the Eclipse integration finally happening!

docs/editors/overview.md Outdated Show resolved Hide resolved
Metals works with Eclipse thanks to the
[`metals-eclipse`](https://github.com/scalameta/metals-eclipse) plugin.

![Eclipse demo](https://i.imgur.com/jrmjVf0.gif)

This comment has been minimized.

Copy link
@olafurpg

olafurpg Sep 3, 2019

Member

GIF tip: I recommend trying to minimize the screen size and minimize the length. In this particular case, it might be enough to demonstrate a single completion + single diagnostic. Heavy GIFs make the website slower to load. Our landing page + overview pages are already too fat 😅

This comment has been minimized.

Copy link
@tgodzik

tgodzik Sep 3, 2019

Author Collaborator

I will try to minimize that.

This comment has been minimized.

Copy link
@tgodzik

tgodzik Sep 4, 2019

Author Collaborator

Should be better :)

docs/editors/eclipse.md Show resolved Hide resolved
@tgodzik tgodzik force-pushed the tgodzik:add-eclipse-site branch from cfe2cb3 to 443d317 Sep 4, 2019
@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 4, 2019

@mundacho We should most likely release the latest version with metals.http=true before merging this. Do you need help setting up the Travis job?

@mundacho

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

hi, I'll do the travis job this afternoon, there should be no problem I think. do you have some particular place where I should do this? Or do I just use my personal travis-ci account (I just created one)

@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 4, 2019

hi, I'll do the travis job this afternoon, there should be no problem I think. do you have some particular place where I should do this? Or do I just use my personal travis-ci account (I just created one)

Best to do it on the Scalameta one. Maybe @olafurpg activate it for https://travis-ci.org/scalameta/metals-eclipse ?

@gabro

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Best to do it on the Scalameta one. Maybe @olafurpg activate it for travis-ci.org/scalameta/metals-eclipse ?

done 👍

@mundacho

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

The travis job is setup, I updated the readme file to document the release process.

@tgodzik tgodzik merged commit 679f6b7 into scalameta:master Sep 5, 2019
1 of 2 checks passed
1 of 2 checks passed
scalameta.metals Build #20190904.3 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.