Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry with clean compiler after ShutdownReq #898

Merged
merged 2 commits into from Sep 5, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Sep 4, 2019

Follow from #873 - this should finally fix the issues with tests and possibly more.

@tgodzik tgodzik requested a review from olafurpg Sep 4, 2019
@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 4, 2019

Now it shows up as:

INFO  tests.TestingServer#didOpen
INFO  tests.TestingServer#didOpen
Sep 04, 2019 5:51:55 PM scala.meta.internal.pc.CompilerAccess retryWithCleanCompiler
INFO: compiler crashed due to an error in the Scala compiler, retrying with new compiler instance.
INFO  tests.TestingServer#didChange
@olafurpg olafurpg merged commit 2c5a619 into scalameta:master Sep 5, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190904.6 succeeded
Details
@olafurpg

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

🤞

@tgodzik tgodzik deleted the tgodzik:fix-shutdown-req branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.