Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt to 1.3.0 #905

Merged
merged 3 commits into from Sep 7, 2019

Conversation

@gabro
Copy link
Member

commented Sep 6, 2019

Let's give this a spin.

I've also taken the chance to upgrade the recommendedVersion in SbtBuildTool

gabro added 2 commits Sep 6, 2019
@gabro

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

The error we see in the CI is caused by the @implNote tag in the Javadoc of PresentationCompiler.java.

Repro with

sbt
> interfaces / Compile / doc

Removing the offending tag fixes the issue, but I would like to understand this a bit better first.

@gabro

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

Ok, apparently @implNote (together with @implSpec and @apiNote) is not recognized by default in Javadoc (despite them being used frequently in Java 8 own docs), so it has to be enabled with the -tag flag.

I'm not sure why this was working at all before, but at least the failure makes sense now. My last commit should fix it.

@gabro gabro requested a review from olafurpg Sep 7, 2019
Copy link
Member

left a comment

Nice! I’m very excited to try out sbt 1.3!

@gabro gabro merged commit fabfc6a into scalameta:master Sep 7, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190907.1 succeeded
Details
@gabro gabro deleted the gabro:sbt-1.3.0 branch Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.