Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 2.12.10 support and use 2.12.10 on Metals #913

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@gabro
Copy link
Member

commented Sep 11, 2019

No description provided.

@gabro gabro requested review from olafurpg and tgodzik Sep 11, 2019
@@ -149,7 +149,7 @@ lazy val V = new {
// List of supported Scala versions in SemanticDB. Needs to be manually updated
// for every SemanticDB upgrade.
def supportedScalaVersions =
Seq(scala213, "2.12.8", scala212) ++ deprecatedScalaVersions
Seq(scala213, "2.12.8", "2.12.9", scala212) ++ deprecatedScalaVersions
def deprecatedScalaVersions = Seq("2.12.7", scala211)

This comment has been minimized.

Copy link
@tgodzik

tgodzik Sep 11, 2019

Collaborator

Let's maybe drop 2.12.7 and make 2.12.8 deprecated?

This comment has been minimized.

Copy link
@tgodzik

tgodzik Sep 13, 2019

Collaborator

We can deprecate it with the next version, since it's working now.

@aeons aeons referenced this pull request Sep 13, 2019
@tgodzik tgodzik merged commit 8c55834 into scalameta:master Sep 13, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190911.5 succeeded
Details
@gabro gabro added this to the Metals v0.7.6 milestone Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.