Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky test. #918

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@olafurpg
Copy link
Member

commented Sep 12, 2019

Flaky tests cause more harm than good to the project. This test case was failing the CI for #907

Flaky tests cause more harm than good to the project.
@tgodzik

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

Flaky tests cause more harm than good to the project. This test case was failing the CI for #907

I wonder if the test is actually the issue. Whenever one of those tests fail, we got a log:

INFO  Deduplicating compilation of a from bsp client 'Metals 0.7.3-SNAPSHOT' (since 15.818s)

which when it happened once on my machine, broke the workspace. Looks like a corrupted Bloop instance. I have seen a couple of other tests fail with the same.

Copy link
Collaborator

left a comment

Do you have any insights why this might be flaky? If so, could describe it here and maybe link to the PR in the code before merging? If not, then I think it can be merged without delay.

@gabro

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

It's a sign

image

@tgodzik tgodzik merged commit 73aacbe into scalameta:master Sep 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190912.4 succeeded
Details
@olafurpg olafurpg deleted the olafurpg:flaky-referene branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.