Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify testing when calculating position and automatically add pipes when copy pasting input #919

Merged
merged 2 commits into from Sep 13, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Sep 12, 2019

Previously, when pasting in a multiline string with pipes, formatting in that string would be broken. Now we make sure to insert pipes in proper places.

Fixes #870

…s when copy pasting input

Previously, when pasting in a multiline string with pipes, formatting in that string would be broken. Now we make sure to insert pipes in proper places.
@tgodzik tgodzik requested a review from marek1840 Sep 12, 2019
Copy link
Collaborator

left a comment

Changing # ti | can get a bit confusing when you see:

val code = """
  | val embedded = '''
  |  |
  |  |'''
"""

but that can just be me ;)

@tgodzik tgodzik force-pushed the tgodzik:add-range-formatting branch from 6b2059e to e92ca2d Sep 13, 2019
Copy link
Collaborator

left a comment

One really small suggestion, feel free to ignore

@tgodzik tgodzik force-pushed the tgodzik:add-range-formatting branch from e92ca2d to 992b862 Sep 13, 2019
@tgodzik tgodzik merged commit a5ffd01 into scalameta:master Sep 13, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190913.4 succeeded
Details
@tgodzik tgodzik deleted the tgodzik:add-range-formatting branch Sep 13, 2019
@gabro gabro added this to the Metals v0.7.6 milestone Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.