Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dealias to properly support type #921

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Sep 13, 2019

Seems that it was not neccessary. @olafurpg can you confirm? No tests seem to fail.

Fixes #920

@tgodzik tgodzik requested a review from olafurpg Sep 13, 2019
@gabro
gabro approved these changes Sep 13, 2019
Copy link
Member

left a comment

Make sense to me, as long as all the tests pass.

Copy link
Member

left a comment

LGTM 👍 Good catch!

@tgodzik tgodzik merged commit 886c898 into scalameta:master Sep 13, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190913.6 succeeded
Details
@tgodzik tgodzik deleted the tgodzik:fix-empty-type-snippet branch Sep 13, 2019
@gabro gabro added this to the Metals v0.7.6 milestone Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.