Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap field to type parameter for scala Type #933

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Sep 18, 2019

I was looking earlier through the available SymbolKind and I think this makes more sense when it comes to Type

@tgodzik tgodzik requested a review from olafurpg Sep 18, 2019
@gabro
gabro approved these changes Sep 18, 2019
Copy link
Member

left a comment

LGTM

It's technically a field, but I don't mind distinguishing it from the value fields.

Also, I think TypeParameter is otherwise unused in this context, so 👍

Copy link
Member

left a comment

LGTM 👍 You may need to run save-expect to please the tests

@tgodzik tgodzik force-pushed the tgodzik:fields branch from 4caa69f to 780604a Sep 18, 2019
@tgodzik tgodzik merged commit 9932570 into scalameta:master Sep 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190918.4 succeeded
Details
@tgodzik tgodzik deleted the tgodzik:fields branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.