Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Azure pipelines with GitHub Actions #947

Merged
merged 2 commits into from Sep 27, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Sep 26, 2019

On GitHub Actions we have OpenJDK 8 installed, which doesn't have issues with the nuprocess library that we're using. The tests in #942 (comment) are failing because Azure uses Zulu JDK which doesn't support the same JNA APIs that are used by nuprocess.

Copy link
Collaborator

tgodzik left a comment

Awesome! Hopefully we can get some reliant windows tests

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Sep 26, 2019

Yeah, it would be lovely to re-enable the windows tests.

@tgodzik

This comment has been minimized.

Copy link
Collaborator

tgodzik commented Sep 26, 2019

Yeah, it would be lovely to re-enable the windows tests.

Somehow I thought these were the windows tests :O But could we also run with Github Actions on windows?

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Sep 26, 2019

We haven't been running windows tests since #878 because Appveyor was too unreliable. GitHub Actions supports Windows so it's worth a shot to try again.

This is needed to pass the tests in CI.
@olafurpg olafurpg force-pushed the olafurpg:goodbye-azure branch from 0397050 to 8056580 Sep 26, 2019
@olafurpg olafurpg merged commit 807ca28 into scalameta:master Sep 27, 2019
2 checks passed
2 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@olafurpg olafurpg deleted the olafurpg:goodbye-azure branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.