Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't propose completions for null or nothing #949

Merged
merged 1 commit into from Sep 27, 2019
Merged

Conversation

@tgodzik
Copy link
Collaborator

tgodzik commented Sep 27, 2019

Found it being an issue after adding subtyping.

@tgodzik tgodzik requested review from marek1840 and olafurpg Sep 27, 2019
Copy link
Member

olafurpg left a comment

Nice!

@@ -1,4 +1,4 @@
def localSnapshotVersion = "0.7.6-SNAPSHOT"
def localSnapshotVersion = "0.7.7-SNAPSHOT"

This comment has been minimized.

Copy link
@olafurpg

olafurpg Sep 27, 2019

Member

I was just gonna open a PR to do this ❤️

@tgodzik tgodzik merged commit b8f69aa into scalameta:master Sep 27, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tgodzik tgodzik deleted the tgodzik:noting branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.