Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't file watch inside jar files. #950

Merged
merged 1 commit into from Sep 29, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Sep 27, 2019

The Scala compiler supports a feature where it compiles the output
classfiles directly to *.jar files. This feature is used in build
tools like Pants and Bazel.

Previously, Metals would crash on build targets that used this feature
of the compiler. Now, we don't do anything even if it means missing file
watching notifications that are needed for the "find symbol references"
index.

Thank you @illicitonion for reporting this issue!

The Scala compiler supports a feature where it compiles the output
classfiles directly to `*.jar` files. This feature is used in build
tools like Pants and Bazel.

Previously, Metals would crash on build targets that used this feature
of the compiler. Now, we don't do anything even if it means missing file
watching notifications that are needed for the "find symbol references"
index.
Copy link
Collaborator

tgodzik left a comment

LGTM But is there any way to watch on chages inside the jar? Are you aware of anything?

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Sep 27, 2019

We can file watch the jar itself, and reindex all the SemanticDB files on every change. We can do that in a separate PR, this change is just to fix the current crash.

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Sep 29, 2019

Ignoring independent flaky tests in both GH and Travis.

@olafurpg olafurpg merged commit 4eb048c into scalameta:master Sep 29, 2019
0 of 2 checks passed
0 of 2 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@olafurpg olafurpg deleted the olafurpg:file-watching-crash branch Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.