Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if bloop version is older than 1.3.3 #957

Merged
merged 1 commit into from Oct 5, 2019

Conversation

@tgodzik
Copy link
Collaborator

tgodzik commented Oct 3, 2019

No description provided.

Copy link
Member

olafurpg left a comment

Thanks for looking into this! In the future, it would be nice if Metals can somehow automatically upgrade the Bloop version but for now it's a good improvement to at least notify the user.

@gabro

This comment has been minimized.

Copy link
Member

gabro commented Oct 3, 2019

Maybe we can add this to the doctor view?

@tgodzik tgodzik force-pushed the tgodzik:add-bloop-warning branch 2 times, most recently from c5c7a75 to c98b078 Oct 4, 2019
@tgodzik tgodzik force-pushed the tgodzik:add-bloop-warning branch from c98b078 to 44e6e2e Oct 4, 2019
@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

tgodzik commented Oct 4, 2019

Maybe we can add this to the doctor view?

It's now reported as a recommendation is semanticDB options are not detected. Should work better with anything that is not reimported or snapshot 1.3.2 bloop versions.

@tgodzik tgodzik requested a review from gabro Oct 4, 2019
@gabro
gabro approved these changes Oct 4, 2019
Copy link
Member

gabro left a comment

Looks good!

Copy link
Member

olafurpg left a comment

Awesome!

@tgodzik tgodzik merged commit 7843055 into scalameta:master Oct 5, 2019
2 checks passed
2 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tgodzik tgodzik deleted the tgodzik:add-bloop-warning branch Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.