Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change manual instalation section for sbt, gradle and maven #963

Merged
merged 2 commits into from Oct 5, 2019

Conversation

@tgodzik
Copy link
Collaborator

tgodzik commented Oct 5, 2019

After the next release I will remove the old instructions, since they will no longer be needed.

However, currently the instructions differ if you use snapshots.

Fixes #958

@tgodzik tgodzik requested a review from olafurpg Oct 5, 2019
@@ -22,6 +23,13 @@ couple of steps that are explained in the manual installation section.

## Manual instalation

For current Metals snapshots all you need to run the manual instalation is:

This comment has been minimized.

Copy link
@gabro

gabro Oct 5, 2019

Member

installation

This comment has been minimized.

Copy link
@tgodzik

tgodzik Oct 5, 2019

Author Collaborator

😨 I knew something was wrong

@tgodzik tgodzik force-pushed the tgodzik:fix-documentation branch from 7204cce to f61fa0a Oct 5, 2019
Copy link
Member

olafurpg left a comment

Thank you for updating these. Only a minor suggestion

generate the Bloop JSON files directly from your sbt shell. This approach may
speed up build import by avoiding Metals from starting sbt in a separate
process.

### For current snapshots

This comment has been minimized.

Copy link
@olafurpg

olafurpg Oct 5, 2019

Member

“latest SNAPSHOT”?

@tgodzik tgodzik merged commit 30c2568 into scalameta:master Oct 5, 2019
2 checks passed
2 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tgodzik tgodzik deleted the tgodzik:fix-documentation branch Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.