Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .bloop and .metals paths to gitignore automatically #967

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@ashwinbhaskar
Copy link
Contributor

ashwinbhaskar commented Oct 6, 2019

Fixes #966

@ashwinbhaskar ashwinbhaskar force-pushed the ashwinbhaskar:gitignore_changes branch 3 times, most recently from 0c29251 to 4a2fea0 Oct 6, 2019
@ashwinbhaskar ashwinbhaskar force-pushed the ashwinbhaskar:gitignore_changes branch from 4a2fea0 to b098388 Oct 6, 2019
@tgodzik
tgodzik approved these changes Oct 7, 2019
Copy link
Collaborator

tgodzik left a comment

Looks good, thanks for the contribution! 🎉

@tgodzik tgodzik merged commit c889835 into scalameta:master Oct 7, 2019
2 checks passed
2 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ashwinbhaskar ashwinbhaskar deleted the ashwinbhaskar:gitignore_changes branch Oct 7, 2019
Copy link
Member

olafurpg left a comment

Thank you for this contribution! Just a minor comment, I doubt it's an issue but would be nice to improve

val gitignore = workspace.resolve(".gitignore")
if (gitignore.exists) {
paths
.filterNot(gitignore.readText.contains)

This comment has been minimized.

Copy link
@olafurpg

olafurpg Oct 8, 2019

Member

We're re-reading the .gitignore file on every path. It would be better to bind the value of readText to a variable.

This comment has been minimized.

Copy link
@ashwinbhaskar

ashwinbhaskar Oct 8, 2019

Author Contributor

@olafurpg makes sense! I will do that

ashwinbhaskar added a commit to ashwinbhaskar/metals that referenced this pull request Oct 8, 2019
- Should have been part of PR scalameta#967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.