Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone down "No SemanticDB" warning #973

Merged
merged 1 commit into from Oct 9, 2019
Merged

Conversation

@olafurpg
Copy link
Member

olafurpg commented Oct 8, 2019

Previously, we reported a warning "No SemanticDB" in the status bar when
Metals couldn't find a SemanticDB file for a given source file. Now, we
only log the warning without updating the status bar because this
problem is quite harmless in most situations.

It's difficult to say what the root cause of this problem, my theory is
that it happens in some of the following cases:

  • new Bloop BSP connection with an empty class directory
  • git checkout to a new branch where new files got added and the file
    hasn't been compiled yet.

Either way, it's not the end of the world when the SemanticDB file
doesn't exist. Most functionality including completions, type at
point,parameter hints and goto definition should continue to work.

cc/ @bishabosha

Previously, we reported a warning "No SemanticDB" in the status bar when
Metals couldn't find a SemanticDB file for a given source file. Now, we
only log the warning without updating the status bar because this
problem is quite harmless in most situations.

It's difficult to say what the root cause of this problem, my theory is
that it happens in some of the following cases:

- new Bloop BSP connection with an empty class directory
- git checkout to a new branch where new files got added and the file
  hasn't been compiled yet.

Either way, it's not the end of the world when the SemanticDB file
doesn't exist. Most functionality including completions, type at
point,parameter hints and goto definition should continue to work.
@bishabosha

This comment has been minimized.

Copy link

bishabosha commented Oct 8, 2019

LGTM

@gabro
gabro approved these changes Oct 8, 2019
Copy link
Member

gabro left a comment

I agree this is causes more worry than necessary 👌

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Oct 9, 2019

Ignoring unrelated CI failure, see #975

@olafurpg olafurpg merged commit 014aae7 into scalameta:master Oct 9, 2019
0 of 2 checks passed
0 of 2 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@olafurpg olafurpg deleted the olafurpg:no-semanticdb branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.