Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor slow suite name #977

Merged
merged 2 commits into from Oct 10, 2019
Merged

Refactor slow suite name #977

merged 2 commits into from Oct 10, 2019

Conversation

@ckipp01
Copy link
Member

ckipp01 commented Oct 10, 2019

Relates to #672

This PR changes the name of the SlowSuite to LspSuite and updates documentation.

Since I was poking around at all the tests anyway I figured it was easy enough to do some renaming while in there. Hopefully, this is what you were getting at in your original comment @olafurpg. If not, let me know!

Copy link
Member

olafurpg left a comment

Thank you for this contribution! It looks like there are a few comments still referencing SlowSuite

$ rg SlowSuite
docs/contributors/getting-started.md
71:Every test suite that extends `SlowSuite` generates a workspace directory under
74:example, for the test case `"deprecated-scala"` in `WarningsSlowSuite` run the

tests/lsp/src/test/scala/tests/BaseImportSuite.scala
50:      // Skip SbtSlowSuite on Windows because they're flaky due to likely the small

mtags/src/main/scala/scala/meta/internal/pc/MetalsGlobal.scala
354:  // NOTE(olafur): see compiler plugin test cases in `CompletionSlowSuite`

Otherwise, looks good to me 👍

docs/contributors/getting-started.md Outdated Show resolved Hide resolved
@ckipp01 ckipp01 force-pushed the ckipp01:refactor-slow-suite branch from b162cec to c68714b Oct 10, 2019
Copy link
Collaborator

tgodzik left a comment

LGTM

@tgodzik tgodzik merged commit 20d2d4f into scalameta:master Oct 10, 2019
2 checks passed
2 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ckipp01 ckipp01 deleted the ckipp01:refactor-slow-suite branch Oct 10, 2019
@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Oct 10, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.