Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install bloop server in CI #982

Merged
merged 2 commits into from Oct 17, 2019
Merged

Install bloop server in CI #982

merged 2 commits into from Oct 17, 2019

Conversation

@sswistun-vl
Copy link
Collaborator

sswistun-vl commented Oct 11, 2019

Previously, the CI tests were run using an embedded Bloop server. Recently the tests started to time in CI. This PR changes the tests in CI to use an installed Bloop server instead of the embedded Bloop server.

The tests are still failing but no longer timing out, which is an improvmement.

@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch 6 times, most recently from 1404a0f to 1784d04 Oct 11, 2019
.travis.yml Outdated Show resolved Hide resolved
@tgodzik tgodzik changed the title Global Bloop for all tests WiP: Global Bloop for all tests Oct 11, 2019
@olafurpg olafurpg changed the title WiP: Global Bloop for all tests Install bloop server on Travis CI Oct 13, 2019
@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch from f75242e to 7bf0d24 Oct 14, 2019
Copy link
Collaborator

marek1840 left a comment

There is a whole pipeline, which could be extracted to a script:

script:
  bin/test.sh tests.feature
script:
  bin/test.sh tests.maven

this script would then:

  1. download bloop (potentially into target or some other, untracked directory)
  2. run sbt task
  3. print output
.travis.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch from 7bf0d24 to c486252 Oct 14, 2019
bin/travis/test.sh Outdated Show resolved Hide resolved
bin/travis/test.sh Outdated Show resolved Hide resolved
bin/travis/tools.sh Outdated Show resolved Hide resolved
@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch 2 times, most recently from 0e26329 to 5131895 Oct 14, 2019
bin/travis/test.sh Outdated Show resolved Hide resolved
@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch 2 times, most recently from 28cdf76 to 040f2c8 Oct 14, 2019
Copy link
Collaborator

tgodzik left a comment

Cool! Looks much better now :)

@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch from c2d4794 to dc7ffb6 Oct 15, 2019
@tgodzik tgodzik requested review from marek1840 and olafurpg Oct 15, 2019
bin/travis/test.sh Outdated Show resolved Hide resolved
bin/travis/test.sh Outdated Show resolved Hide resolved
@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch 2 times, most recently from 6b7b766 to 59f894f Oct 16, 2019
Copy link
Member

olafurpg left a comment

Any idea what's causing the test failures in Travis?

project/metals.sbt

This comment has been minimized.

Copy link
@olafurpg

olafurpg Oct 16, 2019

Member

Should this change be included?

This comment has been minimized.

Copy link
@tgodzik

tgodzik Oct 16, 2019

Collaborator

That's fine, we want to have it gitignored

@sswistun-vl

This comment has been minimized.

Copy link
Collaborator Author

sswistun-vl commented Oct 16, 2019

I'm trying to find the reason why it fails here but passes on #993

@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch from 5b6e575 to ff70adb Oct 16, 2019
@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch 2 times, most recently from 8c01939 to c26dcc2 Oct 16, 2019
@sswistun-vl sswistun-vl force-pushed the sswistun-vl:patch-1 branch from 79fc926 to 57ca1f2 Oct 17, 2019
@olafurpg olafurpg changed the title Install bloop server on Travis CI Install bloop server in CI Oct 17, 2019
@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Oct 17, 2019

LGTM 👍 the failing tests are unrelated to this change and apparently @tgodzik is working on a separate fix for them.

@olafurpg olafurpg merged commit 11a27ae into scalameta:master Oct 17, 2019
1 of 3 checks passed
1 of 3 checks passed
build build
Details
scalameta.metals Build #20191017.4 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.