Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Keep code lenses after error until next successful compilation #994
Also: a) remove promises from build target classes Since we make sure to force the codeLens request after compilation, there is no need to use a promise - we have a guarantee that after the refreshModel notification is sent to the client, the classes are already up to date b) emove workspace after each lsp test Otherwise, running a test once could have an impact on consecutive runs (try CodeLensLspSuite without this change - bloop analysis from previous compilation is affecting the results)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.