Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Tree View update notification on first no-op compilation. #997

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Oct 17, 2019

Fixes #846. Previously, Metals didn't send tree view update
notifications on no-op compilations under the assumption that the tree
view wouldn't change since it was an empty compilation. However, this
assumption was wrong when an empty compilation is the first compilation
of a build server connection because the Bloop build server may have
copied over classfiles to the BSP session class directory.

Now, Metals will send a tree view update compilation for the first
compiation even if it's empty ensuring the tree view properly picks up
the latest outlines from the project.

Fixes #846. Previously, Metals didn't send tree view update
notifications on no-op compilations under the assumption that the tree
view wouldn't change since it was an empty compilation. However, this
assumption was wrong when an empty compilation is the first compilation
of a build server connection because the Bloop build server may have
copied over classfiles to the BSP session class directory.

Now, Metals will send a tree view update compilation for the first
compiation even if it's empty ensuring the tree view properly picks up
the latest outlines from the project.
@olafurpg olafurpg force-pushed the olafurpg:no-op branch from 4380a7e to 9c9e425 Oct 17, 2019
Copy link
Collaborator

tgodzik left a comment

LGTM! Thanks for looking into this 🎉

@tgodzik tgodzik merged commit bb098f8 into scalameta:master Oct 18, 2019
2 of 3 checks passed
2 of 3 checks passed
build
Details
scalameta.metals Build #20191017.14 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@olafurpg olafurpg deleted the olafurpg:no-op branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.