Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip "metals." prefix from `workspace/executeCommand` requests. #998

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Oct 17, 2019

This allows clients to optionally choose whether to include a
"metals." prefix or not. Fixes #838.

@olafurpg olafurpg requested a review from tgodzik Oct 17, 2019
This allows clients to optionally choose whether to include a
`"metals."` prefix or not. Fixes #838.
@olafurpg olafurpg force-pushed the olafurpg:commands branch from 2aeedc7 to f4f8a0d Oct 17, 2019
Copy link
Collaborator

tgodzik left a comment

Looks good!

@tgodzik tgodzik merged commit 1dfcd90 into scalameta:master Oct 17, 2019
1 of 3 checks passed
1 of 3 checks passed
build build
Details
scalameta.metals Build #20191017.15 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.