New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro call reformatting isn't great #360

Closed
djspiewak opened this Issue Jul 5, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@djspiewak
Contributor

djspiewak commented Jul 5, 2016

Original:

  implicit def adtSyntax[A](target: A): Any =
    macro LiftMacros.materializeADTSyntax[A]

Scalafmt:

  implicit def adtSyntax[A](target: A): Any = macro LiftMacros
    .materializeADTSyntax[A]

I would like the input to look like this:

  implicit def adtSyntax[A](target: A): Any =
    macro LiftMacros.materializeADTSyntax[A]

Using:

  • 0.2.x
--maxColumn 80
--continuationIndentCallSite 2
--allowNewlineBeforeColonInMassiveReturnTypes false
--binPackParentConstructors false
--alignByArrowEnumeratorGenerator false
--alignByOpenParenCallSite false
--javaDocs

@olafurpg olafurpg added this to the 0.2.11 milestone Jul 6, 2016

@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Jul 6, 2016

Member

I agree. Even surprised that scalafmt produces this output, assigning for next big release.

Member

olafurpg commented Jul 6, 2016

I agree. Even surprised that scalafmt produces this output, assigning for next big release.

@olafurpg olafurpg modified the milestones: 0.2.12, 0.2.11 Jul 8, 2016

@olafurpg olafurpg closed this in eb771cf Aug 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment