New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A `!` gets combined with `===` resulting in compilation error #697

Closed
ochrons opened this Issue Jan 25, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@ochrons

ochrons commented Jan 25, 2017

This template is a guideline, not a strict requirement.

  • Version: 0.5.3
  • Integration: SBT
  • Configuration:
style = defaultWithAlign
maxColumn = 140

Unexpected formatting output

  def ===(that: S): Boolean

  def =!=(that: S): Boolean = ! ===(that)

gets formatted to

  def ===(that: S): Boolean

  def =!=(that: S): Boolean = !===(that)

which doesn't compile due to !===

@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Jan 25, 2017

Member

I clearly need to point my test suite against your repos! I run checks to verify that scalafmt does not change the AST. Thanks for reporting, I'll try to get this fixed asap.

Member

olafurpg commented Jan 25, 2017

I clearly need to point my test suite against your repos! I run checks to verify that scalafmt does not change the AST. Thanks for reporting, I'll try to get this fixed asap.

@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Jan 26, 2017

Member

I was able to reproduce and #698 is a fix. I'll try to publish 0.5.4 today.

Member

olafurpg commented Jan 26, 2017

I was able to reproduce and #698 is a fix. I'll try to publish 0.5.4 today.

@olafurpg olafurpg closed this in 5c7f1cd Jan 26, 2017

olafurpg added a commit that referenced this issue Jan 26, 2017

Merge pull request #698 from olafurpg/697
Fix #697, unary operator to symbolic ident
@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Jan 26, 2017

Member

0.5.4 is on its way to maven and intellij plugin repository.

Member

olafurpg commented Jan 26, 2017

0.5.4 is on its way to maven and intellij plugin repository.

@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Feb 2, 2017

Member

Seems like the fix for this bug was too aggressive, it adds spaces when it's not necessary

-    assert(!_evaluatorSet, "Evaluator can be set at most once")
+    assert(! _evaluatorSet, "Evaluator can be set at most once")
Member

olafurpg commented Feb 2, 2017

Seems like the fix for this bug was too aggressive, it adds spaces when it's not necessary

-    assert(!_evaluatorSet, "Evaluator can be set at most once")
+    assert(! _evaluatorSet, "Evaluator can be set at most once")

@olafurpg olafurpg reopened this Feb 2, 2017

@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Feb 2, 2017

Member

Guess this belongs to a separate issue.

Member

olafurpg commented Feb 2, 2017

Guess this belongs to a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment