New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optIn.breaksInsideChains = true #1037

Merged
merged 2 commits into from Sep 11, 2017

Conversation

3 participants
@olafurpg
Member

olafurpg commented Sep 7, 2017

This option makes it possible to control line breaks around select
chains. Fixes #988.

Review @xerial @LMnet

Add optInt.breaksInsideChains = true
This option makes it possible to control line breaks around select
chains. Fixes #988.

@olafurpg olafurpg changed the title from Add optInt.breaksInsideChains = true to Add optIn.breaksInsideChains = true Sep 7, 2017

@xerial

This comment has been minimized.

Show comment
Hide comment
@xerial

xerial Sep 7, 2017

Thanks. I'll test this version of scalafmt to re-format https://github.com/wvlet/airframe/.

xerial commented Sep 7, 2017

Thanks. I'll test this version of scalafmt to re-format https://github.com/wvlet/airframe/.

@LMnet

This comment has been minimized.

Show comment
Hide comment
@LMnet

LMnet Sep 8, 2017

Thanks for the fix! I'll try to check it in a few days.

LMnet commented Sep 8, 2017

Thanks for the fix! I'll try to check it in a few days.

@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Sep 8, 2017

Member

No rush from my side 😄

Member

olafurpg commented Sep 8, 2017

No rush from my side 😄

@LMnet

This comment has been minimized.

Show comment
Hide comment
@LMnet

LMnet Sep 10, 2017

I tested new option and all works as expected.

Just for clearness - what is the purpose of empty scalafmt-tests/src/test/resources/optIn/SelectChains file?

LMnet commented Sep 10, 2017

I tested new option and all works as expected.

Just for clearness - what is the purpose of empty scalafmt-tests/src/test/resources/optIn/SelectChains file?

@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Sep 10, 2017

Member

Good to hear @LMnet I've removed that file, good catch!

Member

olafurpg commented Sep 10, 2017

Good to hear @LMnet I've removed that file, good catch!

@xerial

This comment has been minimized.

Show comment
Hide comment
@xerial

xerial Sep 11, 2017

@olafurpg Tested this version in wvlet/airframe#103 and this option works really well :)

Could you release this version for sbt 1.0.0 and 0.13.x? Personally I'd like to use 1.0.0 but some sbt plugins are not fully migrated to 1.0.0 yet (e.g., 47deg/sbt-microsites#221), so it would be great if it can be used with sbt 0.13.x.

xerial commented Sep 11, 2017

@olafurpg Tested this version in wvlet/airframe#103 and this option works really well :)

Could you release this version for sbt 1.0.0 and 0.13.x? Personally I'd like to use 1.0.0 but some sbt plugins are not fully migrated to 1.0.0 yet (e.g., 47deg/sbt-microsites#221), so it would be great if it can be used with sbt 0.13.x.

@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Sep 11, 2017

Member

Good to hear @xerial com:geirsson:sbt-scalafmt doesn't support sbt 0.13 but neo-sbt-scalafmt does https://github.com/lucidsoftware/neo-sbt-scalafmt

I personally use the cli bootstrap script

wget -L https://github.com/scalameta/scalafmt/raw/master/scalafmt
chmod +x scalafmt
./scalafmt

commit it to the git repo and run ./scalafmt on CI.
http://scalameta.org/scalafmt/#Coursier

Member

olafurpg commented Sep 11, 2017

Good to hear @xerial com:geirsson:sbt-scalafmt doesn't support sbt 0.13 but neo-sbt-scalafmt does https://github.com/lucidsoftware/neo-sbt-scalafmt

I personally use the cli bootstrap script

wget -L https://github.com/scalameta/scalafmt/raw/master/scalafmt
chmod +x scalafmt
./scalafmt

commit it to the git repo and run ./scalafmt on CI.
http://scalameta.org/scalafmt/#Coursier

@olafurpg olafurpg merged commit 462b41f into scalameta:master Sep 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@olafurpg olafurpg deleted the olafurpg:988 branch Sep 11, 2017

@olafurpg olafurpg modified the milestone: v1.3.0 Sep 11, 2017

@olafurpg

This comment has been minimized.

Show comment
Hide comment
@olafurpg

olafurpg Sep 11, 2017

Member

I just set the deadline for the v1.3.0 milestone to Sept 18th, https://github.com/scalameta/scalafmt/milestone/18 releases usually take a while due to the intellij plugin.

Member

olafurpg commented Sep 11, 2017

I just set the deadline for the v1.3.0 milestone to Sept 18th, https://github.com/scalameta/scalafmt/milestone/18 releases usually take a while due to the intellij plugin.

@olafurpg olafurpg modified the milestone: v1.3.0 Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment