Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
New scalafmt sbt plugin #1085
I renamed old plugin to
Plugin doesn't perform any caching, it just looks to
*Check tasks should definitely throw exceptions (
MessageOnlyExceptions), otherwise they are not usable in the CI since they do not cause a non-zero exit code, hence do not fail the build.
Only minor comments remaining, otherwise I think this plugin is soon ready for people to try out!
I gave the plugin a swing locally and found a few low hanging improvements
I just tried out the plugin on one of my projects and noticed that it formatted files that are excluded with
The setting is used here for example: https://github.com/scalameta/language-server/blob/573863cb1db6bf99ac73f35ac17f733b92044beb/.scalafmt.conf#L12-L15
The idiomatic way to do this in sbt-scalafmt would be to customize
referenced this pull request
Dec 8, 2017
Last fixes look great, we can leave caching for another PR. Only minor nitpick on language of logging, then we're good to merge