TreeOps: structure the details of defns or calls #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olafurpg @tanishiking @poslegm PTAL. |
poslegm
approved these changes
Feb 21, 2020
Current implementation "pretends" traits and classes have no type params and return the number of contructor arguments.
We are about to start using some functionality currently in FormatOps.
We can vastly simplify the RewriteTrailingCommas logic now, and will be able to improve the FormatOps.getApplyArgs logic later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for a number of fixes which require a better understanding of a definition.
Also, we can vastly simplify the RewriteTrailingCommas logic immediately, and will be able to improve the FormatOps.getApplyArgs logic later, allowing us to tuck implicit in multi-arg calls or apply trailing commas to calls with a given arity.
No changes to tests or
scala-repos.