"// format: off" enabled for comments, literals, etc. #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
approved these changes
Mar 9, 2020
| @@ -71,6 +72,11 @@ class FormatWriter(formatOps: FormatOps) { | |||
| } | |||
|
|
|||
| entry.formatWhitespace(sb) | |||
There was a problem hiding this comment.
just curious: will this introduce any (unwanted) alignment here if format:off had been used?
There was a problem hiding this comment.
Good catch, fixed in 1589507
There was a problem hiding this comment.
Sorry, didn't occur to me before: what about multiple spaces in the original code? Perhaps we should just add the contents of FormatToken.between?
There was a problem hiding this comment.
Added test for multiple spaces 3185a37 Or did you mean other cases?
scalafmt-core/shared/src/main/scala/org/scalafmt/internal/FormatWriter.scala
Outdated
Show resolved
Hide resolved
kitbellew
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1424