Explain limitations of newlines.afterCurlyLambdaParams #2824
Conversation
docs/configuration.md
Outdated
| @@ -1725,6 +1725,9 @@ something.map { x => | |||
| something.map { x => f(x) } | |||
| ``` | |||
|
|
|||
| `afterCurlyLambdaParams` cannot be used with `newlines.source = fold` or | |||
There was a problem hiding this comment.
-
is that really true? it doesn't work for any value, or just keep? or did i perhaps make a mistake in the validation code, and in reality it would work even for keep?
-
if this doesn't work, then we should remove the example comments which mention behavior when source is fold or unfold.
There was a problem hiding this comment.
This is due to https://github.com/scalameta/scalafmt/blob/master/scalafmt-core/shared/src/main/scala/org/scalafmt/config/ScalafmtConfig.scala#L293 I think and newlines.sourceIgnored is true for fold and unfold.
There was a problem hiding this comment.
exactly. i was saying that perhaps this check should be removed, and the formatter will do the right thing.
There was a problem hiding this comment.
I left the check for fold since these options do not work together, keep will be overriden by fold
tgodzik
force-pushed
the
update-docs
branch
2 times, most recently
from
edd98b7
to
4601611
Compare
Also allow to use `newlines.afterCurlyLambdaParams.keep` with `newlines.source.unfold`
Fixes #2822