Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-build for Scala Native. #1529

Merged
merged 7 commits into from May 11, 2018
Merged

Cross-build for Scala Native. #1529

merged 7 commits into from May 11, 2018

Conversation

olafurpg
Copy link
Member

This PR enables Scala Native for all of the modules that currently build for Scala.js, including

  • org.scalameta:scalameta the core umbrella module containing syntactic + semantic API
  • org.scalameta:contrib

The modules that are not build against Scala Native are

  • metacp, depends on ASM which is a Java library
  • semanticdb-scalac, depends on scala-compiler which is JVM only

Most of the workarounds are copy-pasted from
#1243
I validated that the workarounds are necessary by first trying to run
the build without them.

The commented out tests show that there is some work left to be done to
bridge the gap between JS/JVM/Native. However, given that over 99% of
the tests pass should be a big enough milestone to justify merging and
leave the remaining issues for followup PRs.

Most of the workarounds are copy-pasted from
scalameta#1243
I validated that the workarounds are necessary by first trying to run
the build without them.

The commented out tests show that there is some work left to be done to
bridge the gap between JS/JVM/Native. However, given that over 99% of
the tests pass should be a big enough milestone to justify merging and
leave the remaining issues for followup PRs.
Copied from the scala-native repo, trying to fix

```
E: Unable to locate package libunwind8-dev
```
```
Running apt-get update by default has been disabled.
You can opt into running apt-get update by setting this in your
.travis.yml file:

addons:
  apt:
    update: true
```
@olafurpg
Copy link
Member Author

The CI failures seems to have been fixed with

addons:
  apt:
    update: true

@olafurpg olafurpg merged commit 6a8d24b into scalameta:master May 11, 2018
@olafurpg olafurpg deleted the rocket branch May 11, 2018 06:50
@olafurpg olafurpg mentioned this pull request May 11, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants