Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] [BREEZE-590] DenseTensor Implementation #695
The primary design choice I made is to choose TensorN over Tensor3, Tensor4 etc. This does give away static type safety, but brings in flexibility in choosing dimensions of the Tensor.
I have in mind the following checklist to complete this patch in the current form:
Please feel free to suggest more items to add to the checklist. Thank you.
dlwh left a comment
so sorry for the slow response. Thanks for taking this on!
This has the general right shape (heh) for a dynamically-shaped tensor. The biggest problem is that it's too slow of an implementation, and it's important to me that Breeze generally be fast.
The formatting's also not standard Scala, mostly because of the positions of
I'm also just unsure of how to go about implementing the "tensor-y" functions. I'm specifically interested in the generalization of matrix multiplication as well as dimension-reduction operations (e.g. summing out two dimensions of the tensor)
To do this, would you prefer me introducing a new type, say