-
Notifications
You must be signed in to change notification settings - Fork 40
Rename parameters from ScalarDB to ScalarDb #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the naming convention by renaming all instances of ScalarDB-related identifiers to use "ScalarDb" instead.
- Renamed all occurrences of ScalarDBMode to ScalarDbMode.
- Renamed all occurrences of ScalarDBDao and ScalarDBDaoException to ScalarDbDao and ScalarDbDaoException.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| JsonImportProcessorTest.java | Updated import statements and variable declarations to use ScalarDbMode and ScalarDbDao. |
| CsvImportProcessorTest.java | Updated import statements and variable declarations to use ScalarDbMode and ScalarDbDao. |
| ScalarDbDaoTest.java | Renamed class and instance from ScalarDBDao to ScalarDbDao. |
| JsonLineExportManagerTest.java | Updated import statements and exception types to use ScalarDbDao and ScalarDbDaoException. |
| JsonExportManagerTest.java | Updated import statements and exception types to use ScalarDbDao and ScalarDbDaoException. |
| CsvExportManagerTest.java | Updated import statements and exception types to use ScalarDbDao and ScalarDbDaoException. |
| ImportTransactionalTask.java | Updated exception references from ScalarDBDaoException to ScalarDbDaoException. |
| ImportTaskParams.java | Updated import and field types to scalar Db versions. |
| ImportTask.java | Updated exception references from ScalarDBDaoException to ScalarDbDaoException. |
| ImportStorageTask.java | Updated exception references from ScalarDBDaoException to ScalarDbDaoException. |
| ImportProcessorParams.java | Updated import and field types to use ScalarDbDao and ScalarDbMode. |
| ImportProcessor.java | Updated references to ScalarDBMode to ScalarDbMode. |
| ScalarDbDaoException.java | Renamed class from ScalarDBDaoException to ScalarDbDaoException. |
| ScalarDbDao.java | Renamed class and updated logger references accordingly. |
| ImportManager.java | Updated instantiation and references from ScalarDBDao to ScalarDbDao and ScalarDBMode to ScalarDbMode. |
| JsonLineExportManager.java | Updated constructor parameter type from ScalarDBDao to ScalarDbDao. |
| JsonExportManager.java | Updated constructor parameter type from ScalarDBDao to ScalarDbDao. |
| ExportManager.java | Updated member variable types and exception handling from ScalarDBDao to ScalarDbDao. |
| CsvExportManager.java | Updated constructor parameter type from ScalarDBDao to ScalarDbDao. |
| ScalarDbMode.java | Renamed enum from ScalarDBMode to ScalarDbMode. |
Torch3333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
brfrn169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
I have renamed all variable names starting with
ScalarDBtoScalarDbbased on feedback from Suzuki-sanRelated issues and/or PRs
This PR should be reviewed and merged after the following PR is merged.
Changes made
I have updated variable names
ScalarDBtoScalarDbsuch as ScalarDbDao, ScalaDbModeChecklist
Additional notes (optional)
NA
Release notes
NA