Skip to content

Conversation

@inv-jishnu
Copy link
Contributor

@inv-jishnu inv-jishnu commented Apr 4, 2025

Description

I have renamed all variable names starting with ScalarDB to ScalarDb based on feedback from Suzuki-san

Related issues and/or PRs

This PR should be reviewed and merged after the following PR is merged.

Changes made

I have updated variable names ScalarDB to ScalarDb such as ScalarDbDao, ScalaDbMode

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

NA

Release notes

NA

@ypeckstadt ypeckstadt requested review from Copilot and ypeckstadt May 12, 2025 05:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the naming convention by renaming all instances of ScalarDB-related identifiers to use "ScalarDb" instead.

  • Renamed all occurrences of ScalarDBMode to ScalarDbMode.
  • Renamed all occurrences of ScalarDBDao and ScalarDBDaoException to ScalarDbDao and ScalarDbDaoException.

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
JsonImportProcessorTest.java Updated import statements and variable declarations to use ScalarDbMode and ScalarDbDao.
CsvImportProcessorTest.java Updated import statements and variable declarations to use ScalarDbMode and ScalarDbDao.
ScalarDbDaoTest.java Renamed class and instance from ScalarDBDao to ScalarDbDao.
JsonLineExportManagerTest.java Updated import statements and exception types to use ScalarDbDao and ScalarDbDaoException.
JsonExportManagerTest.java Updated import statements and exception types to use ScalarDbDao and ScalarDbDaoException.
CsvExportManagerTest.java Updated import statements and exception types to use ScalarDbDao and ScalarDbDaoException.
ImportTransactionalTask.java Updated exception references from ScalarDBDaoException to ScalarDbDaoException.
ImportTaskParams.java Updated import and field types to scalar Db versions.
ImportTask.java Updated exception references from ScalarDBDaoException to ScalarDbDaoException.
ImportStorageTask.java Updated exception references from ScalarDBDaoException to ScalarDbDaoException.
ImportProcessorParams.java Updated import and field types to use ScalarDbDao and ScalarDbMode.
ImportProcessor.java Updated references to ScalarDBMode to ScalarDbMode.
ScalarDbDaoException.java Renamed class from ScalarDBDaoException to ScalarDbDaoException.
ScalarDbDao.java Renamed class and updated logger references accordingly.
ImportManager.java Updated instantiation and references from ScalarDBDao to ScalarDbDao and ScalarDBMode to ScalarDbMode.
JsonLineExportManager.java Updated constructor parameter type from ScalarDBDao to ScalarDbDao.
JsonExportManager.java Updated constructor parameter type from ScalarDBDao to ScalarDbDao.
ExportManager.java Updated member variable types and exception handling from ScalarDBDao to ScalarDbDao.
CsvExportManager.java Updated constructor parameter type from ScalarDBDao to ScalarDbDao.
ScalarDbMode.java Renamed enum from ScalarDBMode to ScalarDbMode.

@ypeckstadt ypeckstadt marked this pull request as ready for review May 12, 2025 05:20
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit b20d159 into master May 13, 2025
55 checks passed
@feeblefakie feeblefakie deleted the feat/data-loader/update-name branch May 13, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants