Skip to content

Conversation

@thongdk8
Copy link
Contributor

@thongdk8 thongdk8 commented Nov 6, 2025

Description

This PR addresses SLF4J dependency conflicts by excluding the slf4j-api module from the AlloyDB JDBC connector dependency (it is using v2 of slf4j-api while we are using v1.7 in our project). Without the exclusion, the logging behavior will not work correctly, especially in the Data Loader, and the Schema Loader will show a warning SLF4J(W): No SLF4J providers were found.

Related issues and/or PRs

NA

Changes made

  • Exclude the slf4j-api module from the AlloyDB JDBC connector dependency

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

NA

Release notes

Exclude slf4j-api from alloydb dependency to correct logging behaviour

@thongdk8 thongdk8 requested a review from Copilot November 6, 2025 02:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses SLF4J dependency conflicts by excluding the slf4j-api module from the AlloyDB JDBC connector dependency, ensuring consistent logging framework usage across the project.

  • Added an exclusion block for slf4j-api to the AlloyDB JDBC connector dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thongdk8 thongdk8 self-assigned this Nov 6, 2025
@thongdk8 thongdk8 added the bugfix label Nov 6, 2025
@thongdk8 thongdk8 marked this pull request as ready for review November 6, 2025 02:29
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@ypeckstadt ypeckstadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 8b39473 into master Nov 7, 2025
194 of 196 checks passed
@brfrn169 brfrn169 deleted the fix/exclude-slf4j-from-alloydb branch November 7, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants