-
Notifications
You must be signed in to change notification settings - Fork 40
Exclude slf4j-api from alloydb dependency to correct logging behaviour #3119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses SLF4J dependency conflicts by excluding the slf4j-api module from the AlloyDB JDBC connector dependency, ensuring consistent logging framework usage across the project.
- Added an exclusion block for
slf4j-apito the AlloyDB JDBC connector dependency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Torch3333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
ypeckstadt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
brfrn169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR addresses SLF4J dependency conflicts by excluding the slf4j-api module from the AlloyDB JDBC connector dependency (it is using v2 of
slf4j-apiwhile we are using v1.7 in our project). Without the exclusion, the logging behavior will not work correctly, especially in the Data Loader, and the Schema Loader will show a warningSLF4J(W): No SLF4J providers were found.Related issues and/or PRs
NA
Changes made
Checklist
Additional notes (optional)
NA
Release notes
Exclude slf4j-api from alloydb dependency to correct logging behaviour