Skip to content

Backport to branch(3) : Bump the dependencies group across 1 directory with 10 updates #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Backport to branch(3) : Bump the dependencies group across 1 directory with 10 updates #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,26 +29,26 @@ subprojects {
guiceVersion = '5.1.0'
guavaVersion = '32.1.3-jre'
slf4jVersion = '1.7.36'
log4jVersion = '2.25.0'
log4jVersion = '2.25.1'
jsonpVersion = '1.1.4'
jacksonVersion = '2.19.1'
jacksonVersion = '2.19.2'
toml4jVersion = '0.7.2'
scalarDbVersion = '3.16.0'
scalarDbVersion = '3.16.1'
scalarAdminVersion = '2.2.1'
resilience4jRetryVersion = '1.7.1'
dropwizardMetricsVersion = '4.2.33'
prometheusVersion = '0.16.0'
jettyVersion = '9.4.57.v20241219'
assertjVersion = '3.27.3'
junitVersion = '5.13.3'
junitPlatformVersion = '1.13.3'
junitVersion = '5.13.4'
junitPlatformVersion = '1.13.4'
Comment on lines +43 to +44
Copy link

@gemini-code-assist gemini-code-assist bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Maintainability: Consolidate JUnit versions with a BOM

Using separate properties junitVersion and junitPlatformVersion for different components of the same framework can be error-prone, as they might accidentally go out of sync in future updates, leading to potential build failures or runtime issues.

To improve maintainability and ensure all JUnit 5 modules are compatible, I recommend using the JUnit 5 Bill of Materials (BOM). This allows managing all JUnit-related dependency versions with a single property.

You could replace these two properties with a single junitBomVersion and then import the BOM in your subprojects. For example:

// In a subproject's build.gradle
dependencies {
    // Import the BOM (Bill of Materials)
    testImplementation platform("org.junit:junit-bom:${junitBomVersion}")

    // Now, you can declare JUnit dependencies without a version
    testImplementation 'org.junit.jupiter:junit-jupiter-api'
    testImplementation 'org.junit.jupiter:junit-jupiter-params'
}

This change would centralize version control for JUnit, making dependency management simpler and more robust.

mockitoVersion = '4.11.0'
errorproneVersion = '2.10.0'
errorproneJavacVersion = '9+181-r4173-1'
errorpronePluginVersion = '2.0.2'
spotbugsVersion = '4.8.6'
spotbugsPluginVersion = '5.2.5'
commonsTextVersion = '1.13.1'
commonsTextVersion = '1.14.0'
stefanbirknerSystemLambdaVersion = '1.2.1'
googleJavaFormatVersion = '1.7'
dockerPluginVersion = '0.34.0'
Expand Down