TextOutput ignores the --verbose and --quiet command-line flags
#159
Comments
|
A corollary of this issue is that the |
This was referenced Sep 11, 2015
jsirois
pushed a commit
to pantsbuild/pants
that referenced
this issue
Sep 12, 2015
This adds new `--verbose` and `--quiet` options to the `compile.scalastyle` goal, which get threaded directly to scalastyle, as requested in issue #1888. Note: `scalastyle` currently accepts but ignores the `--verbose` option (See: scalastyle/scalastyle#159). However, I include it anyway for when that issue is eventually fixed. Testing Done: $ ./pants test tests/python/pants_test/tasks:scalastyle_integration # Newly added integration test passes $ ./pants test tests/python/pants_test:all # Unit tests pass I'm relying on Travis for the remaining integration tests Bugs closed: 2172 Reviewed at https://rbcommons.com/s/twitter/r/2799/
|
A PR would be great. |
kitbellew
pushed a commit
to kitbellew/scalastyle
that referenced
this issue
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
TextOutputclass takes two arguments namedverboseandquietthat both default tofalse:https://github.com/scalastyle/scalastyle/blob/master/src/main/scala/org/scalastyle/Output.scala#L68
However, the only use of
TextOutputdoes not supply these arguments:scalastyle/src/main/scala/org/scalastyle/Main.scala
Line 112 in bb27685
... so they always default to
false, even if the user supplies--verboseor--quieton the command line.I can submit a pull request to fix this if that is okay with you.
The text was updated successfully, but these errors were encountered: