Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeaderMatchesChecker rule config is missing the regex parameter #321

Closed
mwz opened this issue Sep 2, 2018 · 2 comments
Closed

HeaderMatchesChecker rule config is missing the regex parameter #321

mwz opened this issue Sep 2, 2018 · 2 comments

Comments

@mwz
Copy link

mwz commented Sep 2, 2018

The HeaderMatchesChecker rule is missing the regex parameter in the config file scalastyle_definition.xml.

Existing:

<checker class="org.scalastyle.file.HeaderMatchesChecker" id="header.matches" defaultLevel="warning">
    <parameters>
        <parameter name="header" type="string" multiple="true" default=""/>
    </parameters>
</checker>

What it should be:

<checker class="org.scalastyle.file.HeaderMatchesChecker" id="header.matches" defaultLevel="warning">
    <parameters>
        <parameter name="regex" type="boolean" default="false"/>
        <parameter name="header" type="string" multiple="true" default=""/>
    </parameters>
</checker>
@mwz
Copy link
Author

mwz commented Sep 2, 2018

Looks like this was fixed on master in Oct last year, but it hasn't been released yet. 😮 Any plans to make a release soon?

@mwz
Copy link
Author

mwz commented Feb 23, 2020

Fixed and released in https://github.com/beautiful-scala/scalastyle.

@mwz mwz closed this as completed Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant