Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScalaDocChecker: Add ignoreTokenTypes option #201

Merged
merged 1 commit into from Jul 5, 2016

Conversation

shanielh
Copy link
Contributor

Possible fix for #173

New option named ignoreTokenTypes, the possible values (separated by commas) are :

  • PatDefOrDcl for variables
  • TmplDef for classes / traits
  • TypeDefOrDcl for type definitions
  • FunDefOrDcl for functions

I guess I can change the names of the options to be more indicative.

@codecov-io
Copy link

codecov-io commented Apr 29, 2016

Current coverage is 87.17%

Merging #201 into master will increase coverage by 0.08%

  1. 7 files (not in diff) in ...alastyle/scalariform were modified. more
    • Misses -2
    • Hits +2
  2. 4 files (not in diff) in .../org/scalastyle/file were modified. more
  3. 7 files (not in diff) in ...scala/org/scalastyle were modified. more
    • Misses -7
    • Hits +7
  4. File ...calaDocChecker.scala was modified. more
@@             master       #201   diff @@
==========================================
  Files            56         56          
  Lines          1247       1263    +16   
  Methods        1169       1184    +15   
  Messages          0          0          
  Branches         78         79     +1   
==========================================
+ Hits           1086       1101    +15   
- Misses          161        162     +1   
  Partials          0          0          

Powered by Codecov. Last updated by 2af6c1e...d1a17e5

@matthewfarwell
Copy link
Member

Sorry this has been so long responding. Could you add some documentation as well please?

@shanielh
Copy link
Contributor Author

shanielh commented Jun 16, 2016

Sure, I've updated the resource files, now tests are passing and the branch is rebased 👍

@shanielh
Copy link
Contributor Author

shanielh commented Jul 4, 2016

Waiting for your reply :)

@matthewfarwell matthewfarwell merged commit 129957e into scalastyle:master Jul 5, 2016
@matthewfarwell
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants