...ting it down.
Now that TemplateEngine uses a ScalaCompiler, it needs a method for s…
…hutting it down.
I wonder if it would be better to add shutdown to the Compiler trait. Could default to a no-op. It would eliminate the cast. If not added to the Compiler trait, maybe a pattern match so it doesn't crash on non-ScalaCompilers.
+1 for the shutdown on the trait. Should I re-do the pull request?
Yes, that would be great. Thanks so much!
OK, will do it tomorrow.
Add a shutdown method on Compiler
New commit added to the patch.
Looks great, thanks for the contribution.
I added parens to the shutdown methods. Parens aren't required, but they're good style in methods with side effects.