Now that TemplateEngine uses a ScalaCompiler, it needs a method for shut... #21

Merged
merged 2 commits into from May 3, 2012

2 participants

@slandelle

...ting it down.

@rossabaker
Scalate member

I wonder if it would be better to add shutdown to the Compiler trait. Could default to a no-op. It would eliminate the cast. If not added to the Compiler trait, maybe a pattern match so it doesn't crash on non-ScalaCompilers.

@slandelle

You're right.
+1 for the shutdown on the trait. Should I re-do the pull request?

@rossabaker
Scalate member

Yes, that would be great. Thanks so much!

@slandelle

OK, will do it tomorrow.

@slandelle

New commit added to the patch.

Cheers,

Steph

@rossabaker rossabaker merged commit ae8be2d into scalate:master May 3, 2012
@rossabaker
Scalate member

Looks great, thanks for the contribution.

I added parens to the shutdown methods. Parens aren't required, but they're good style in methods with side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment