Rhino based compilation of Coffeescript for Coffeescript filter #6

Merged
merged 1 commit into from Sep 9, 2011

Projects

None yet

2 participants

@daggerrz

Quick win for server based compilation (based on https://github.com/daggerrz/scala-coffee), but I have a few open questions that need to be answered before merging:

  • How to get access to line number information to give user a more informative error message on Coffee compilation error
  • Is there any reason to keep the browser based compilation at all (even when in dev-mode)?
  • How to handle the Rhino dep. Move to separate module?
@daggerrz

Open questions:

  • How to get access to line number information to give user a more informative error message on Coffee compilation error
  • Is there any reason to keep the browser based compilation at all (even when in dev-mode)?
  • How to handle the Rhino dep. Move to separate module?
@jstrachan jstrachan merged commit 1c73f37 into scalate:master Sep 9, 2011
@jstrachan
@jstrachan

An optional dependency on rhino sounds fine to me; added an enable/disable flag too. Still pondering the line number issue...

@daggerrz

Sounds good, most will probably opt to use the compiler once it's there and for those who don't want the extra dep, a flag should solve their problems. Line numbers would be really useful, but it looks like that will require some refactoring of the Scalate pipeline. I'm not familiar enough with the source to make any suggestions, though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment