New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RicherString#isBlank #864

Open
wants to merge 2 commits into
base: 2.7.x
from

Conversation

Projects
None yet
2 participants
@magnolia-k
Contributor

magnolia-k commented Oct 9, 2018

and added openjdk11 to .travis.yml

Although there is a possibility of further review in the future, I decided to go through the test first.

magnolia-k added some commits Oct 9, 2018

deprecated RicherString#isBlank
Because a method of the same name was added to java.lang.String from Java 11.
(And the behavior is different!)

Instead, the same behavior isBlankString was introduced.
In future it should be replaced with Java 11's isBlank method.
@takezoe

This comment has been minimized.

Member

takezoe commented Oct 10, 2018

In my opinion, such abuse of extension for fundamental classes like String is not good idea. My idea is marking existing methods as deprecated and modify existing code to not use them. How do you think about it? Is this idea unrealistic...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment