incorporate the kind-projector plugin #875

Merged
merged 8 commits into from Jan 8, 2015

Conversation

Projects
None yet
7 participants
@jedws
Contributor

jedws commented Jan 7, 2015

Almost all type-lambdas are rewritten using the kind-projector apart from the ones that it cannot support and those in the examples tree.

Also standardises a lot of formatting, in particular placing anonymous class impls on a new line.

@jedws jedws referenced this pull request Jan 7, 2015

Merged

Free applicative functors #872

@japgolly

This comment has been minimized.

Show comment
Hide comment
@japgolly

japgolly Jan 7, 2015

Contributor

Nice work!

Contributor

japgolly commented Jan 7, 2015

Nice work!

project/build.scala
@@ -161,7 +161,8 @@ object build extends Build {
}
}
</developers>
- )
+ ),
+ addCompilerPlugin("org.spire-math" % "kind-projector_2.10" % "0.5.2")

This comment has been minimized.

@japgolly

japgolly Jan 7, 2015

Contributor

Need Scala 2.11 plugin too right?

@japgolly

japgolly Jan 7, 2015

Contributor

Need Scala 2.11 plugin too right?

This comment has been minimized.

@jedws

jedws Jan 7, 2015

Contributor

fixed

@jedws

jedws Jan 7, 2015

Contributor

fixed

CONTRIBUTING.md
+ F[X, ?] === ({type l[a] = F[X, a]})#l
+ F[X, ?, ?] === ({type l[a, b] = F[X, a, b]})#l
+
+When using Lambda Type Function syntax when kind-projector's inline syntax doesn't work, use greek letters for

This comment has been minimized.

@japgolly

japgolly Jan 7, 2015

Contributor

When using Lambda Type Function syntax and the kind-projector's inline syntax doesn't work clearer, no? Double-when without comma confused poor, fragile me.

@japgolly

japgolly Jan 7, 2015

Contributor

When using Lambda Type Function syntax and the kind-projector's inline syntax doesn't work clearer, no? Double-when without comma confused poor, fragile me.

This comment has been minimized.

@jedws

jedws Jan 7, 2015

Contributor

yeah, hopefully fixed and added a link to the KP doco

@jedws

jedws Jan 7, 2015

Contributor

yeah, hopefully fixed and added a link to the KP doco

@aloiscochard

This comment has been minimized.

Show comment
Hide comment
@aloiscochard

aloiscochard Jan 7, 2015

Contributor

Wow, awesome work @jedws !

Contributor

aloiscochard commented Jan 7, 2015

Wow, awesome work @jedws !

@puffnfresh

This comment has been minimized.

Show comment
Hide comment
@puffnfresh

puffnfresh Jan 7, 2015

Member

Build is failing. Think it's on the check-gen-type-classes sbt task.

Member

puffnfresh commented Jan 7, 2015

Build is failing. Think it's on the check-gen-type-classes sbt task.

+parameters.
+
+ λ[α => (α, α)] === ({type λ[α] = (α, α)})#λ
+ λ[α[_] => F[α] === ({type λ[α[_]] = F[α]})#λ

This comment has been minimized.

@runarorama

runarorama Jan 7, 2015

Member

Use {{ brackets for proper code formatting in editors that are comment-aware?

@runarorama

runarorama Jan 7, 2015

Member

Use {{ brackets for proper code formatting in editors that are comment-aware?

This comment has been minimized.

@jedws

jedws Jan 8, 2015

Contributor

@runarorama Not sure what you mean here, markdown is just four-space indent. I'm merely following the existing style…

@jedws

jedws Jan 8, 2015

Contributor

@runarorama Not sure what you mean here, markdown is just four-space indent. I'm merely following the existing style…

@jedws

This comment has been minimized.

Show comment
Hide comment
@jedws

jedws Jan 8, 2015

Contributor

thanks @puffnfresh think I've fixed it

Contributor

jedws commented Jan 8, 2015

thanks @puffnfresh think I've fixed it

jedws added a commit that referenced this pull request Jan 8, 2015

Merge pull request #875 from jedws/kind-projector
incorporate the kind-projector plugin

@jedws jedws merged commit 466d4da into scalaz:series/7.2.x Jan 8, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@analytically

This comment has been minimized.

Show comment
Hide comment
@analytically

analytically Jan 14, 2015

HTTPS is more secure...

HTTPS is more secure...

@xuwei-k xuwei-k added this to the 7.2 milestone Feb 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment