Skip to content

Correct A100 tag #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Correct A100 tag #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/python/llmengine/data_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class GpuType(str, Enum):

NVIDIA_TESLA_T4 = "nvidia-tesla-t4"
NVIDIA_AMPERE_A10 = "nvidia-ampere-a10"
NVIDIA_AMPERE_A100 = "nvidia-a100"
NVIDIA_AMPERE_A100 = "nvidia-ampere-a100"


class ModelEndpointType(str, Enum):
Expand Down
2 changes: 1 addition & 1 deletion server/llm_engine_server/domain/entities/gpu_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ class GpuType(str, Enum):

NVIDIA_TESLA_T4 = "nvidia-tesla-t4"
NVIDIA_AMPERE_A10 = "nvidia-ampere-a10"
NVIDIA_AMPERE_A100 = "nvidia-a100"
NVIDIA_AMPERE_A100 = "nvidia-ampere-a100"
4 changes: 2 additions & 2 deletions server/tests/unit/common/test_batch_jobs_dtos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ def test_create_docker_image_batch_job_resource_requests_merge_requests():
# Test merging
default = CreateDockerImageBatchJobResourceRequests(cpus=0.5)
override = CreateDockerImageBatchJobResourceRequests(
memory="100Mi", gpus=1, gpu_type="nvidia-a100", storage="10Gi"
memory="100Mi", gpus=1, gpu_type="nvidia-ampere-a100", storage="10Gi"
)
expected = CreateDockerImageBatchJobResourceRequests(
cpus=0.5, memory="100Mi", gpus=1, gpu_type="nvidia-a100", storage="10Gi"
cpus=0.5, memory="100Mi", gpus=1, gpu_type="nvidia-ampere-a100", storage="10Gi"
)
actual = CreateDockerImageBatchJobResourceRequests.merge_requests(default, override)
assert expected == actual
Expand Down