Update client completion timeout #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeng-scale
approved these changes
Aug 30, 2023
saiatmakuri
reviewed
Aug 30, 2023
| ) | ||
|
|
||
|
|
||
| COMPLETION_TIMEOUT = 300 |
Contributor
There was a problem hiding this comment.
i believe most HTTPS connections break after ~60s. imo since it's also a sync endpoint, would it be better to lower this timeout and if the timeout is met, we can ask clients to try again later
Contributor
Author
There was a problem hiding this comment.
I've changed the timeout between spellbookBackend -> Launch gateway to be 5 minutes, need to see if client -> spellbookBackend has a long enough timeout
do you know what usually controls how long it takes for HTTPS connections to break? wondering if it's something we can just set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.