Some fixes #248
Merged
Some fixes #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeng-scale
commented
Sep 1, 2023
| cpus: int = 32, | ||
| memory: str = "192Gi", | ||
| cpus: int = 8, | ||
| memory: str = "40Gi", |
Contributor
Author
There was a problem hiding this comment.
@gargutsav @auag92 i'm updating these default values, so if you're still going with 4 GPUs, please make sure values are set same as how you're using them right now
| resources: | ||
| limits: | ||
| memory: 28Gi | ||
| cpu: 8 |
Contributor
Author
There was a problem hiding this comment.
m5.2xlarge has only 8 CPUs and about 1 is used for system cores
seanshi-scale
approved these changes
Sep 1, 2023
saiatmakuri
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested cache by running locally against prod passing comparison code