Skip to content

adding s3 session function instead of client function #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2023
Merged

adding s3 session function instead of client function #302

merged 1 commit into from
Oct 2, 2023

Conversation

@ian-scale
Copy link
Contributor

@ian-scale ian-scale commented Oct 2, 2023

to fix bug with Model.create().

@ian-scale ian-scale requested a review from sam-scale October 2, 2023 15:11
@ian-scale
Copy link
Contributor Author

ian-scale commented Oct 2, 2023

This was tested locally with logging statements while creating new llama-2-7b endpoints to confirm that the behavior of Model.create() now works.

@ian-scale ian-scale requested a review from a team October 2, 2023 15:13
@ian-scale ian-scale merged commit 6e0bed1 into main Oct 2, 2023
@ian-scale ian-scale deleted the ianmacleod/fix_model_create_bug branch October 2, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@squeakymouse squeakymouse squeakymouse approved these changes

@sam-scale sam-scale sam-scale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ian-scale @squeakymouse @sam-scale @ian-scale-2